Repository navigation
Conversation
tomakehurst
reviewed
Oct 13, 2023
| return new BasicMappingBuilder(RequestMethod.HEAD, urlPattern); | ||
| } | ||
|
|
||
| public static MappingBuilder getOrHead(String method, UrlPattern urlPattern) { |
Member
There was a problem hiding this comment.
I don't think this is the right approach - we should be building the stub mapping with the GET_OR_HEAD request method, then when matching it should match requests with either method and serve the body or not as appropriate.
Author
There was a problem hiding this comment.
Thank you so much for the feedback. I'll incorporate it
Contributor
|
Hi, I think this was implemented in this PR - #2555 Perhaps we could close this one now ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
GET_OR_HEADmethod as the requested issue. Feedback is welcome as this is my first contribution here, might need to change a few things.#2414
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java