Update registration disappears during upgrade. - #622
Merged
Merged
Conversation
barnson
force-pushed
the
bob/UpdateRegistrationAcrossUpgrades
branch
7 times, most recently
from
March 21, 2025 21:00
1ec8c12 to
5d53257
Compare
barnson
changed the title
Update registration is stored in a shared registry key that Burn takes care to keep around across upgrades. The approach it used broke between WiX v3 and WiX v5. This change makes it work again by writing update registration when the session ends.
barnson
force-pushed
the
bob/UpdateRegistrationAcrossUpgrades
branch
from
March 24, 2025 22:18
5d53257 to
f3fb208
Compare
barnson
marked this pull request as ready for review
April 23, 2025 04:07
robmen
self-requested a review
May 28, 2025 23:32
robmen
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update registration is stored in a shared registry key that Burn takes
care to keep around across upgrades. The approach it used broke
between WiX v3 and WiX v5. This change makes it work again by
not rewriting update registration during upgrade uninstall.