Skip to content

Trigger native lib build with a PR comment #437

Description

@xerial

Building native libraries is running at GitHub Actions because I no longer have any local machine using Intel.
Currently, I'm manually triggering native lib build process at https://github.com/xerial/snappy-java/actions/workflows/build-native.yml

It would be convenient if we can trigger such a build if a maintainer comments to a PR (e.g., build native)

Activity

  1. imsudiproy commented on May 23, 2023

    @imsudiproy
    Contributor

    @xerial If I am not wrong. We want to trigger a build when the maintainer comments on a PR with a specific keyword like 'build native'

  2. imsudiproy commented on May 23, 2023

    @imsudiproy
    Contributor

    You can assign this to me. I'll work on this issue

  3. xerial commented on May 23, 2023

    @xerial
    OwnerAuthor

    @imsudiproy Thanks!

    A trigger condition can be simpler like this:

    • Trigger the build if there is a change in some of the following files:
      • src/main/resources/org/xerial/snappy/VERSION file
      • Makefile
      • Makefile.common
      • **/*.h
      • **/*.cpp

    Trigging via PR comment might be unnecessary if the above condition works

  4. imsudiproy commented on May 24, 2023

    @imsudiproy
    Contributor

    Hi @xerial , created a PR for this #444 let me know if any changes required. Thanks

  5. xerial commented on May 24, 2023

    @xerial
    OwnerAuthor

    Thanks. I've tested various approaches, and adopted this one:

    • For PRs: Only testing native library build pass
    • After PR merge, creating (or updating) a new PR with updated native libraries
  6. xerial commented on May 24, 2023

    @xerial
    OwnerAuthor

    Example PR created by this change #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions