Repository navigation
Feature/detection postprocess - #24
Merged
Merged
Conversation
andrewstanfordjason
approved these changes
May 6, 2021
andrewstanfordjason
left a comment
andrewstanfordjason
left a comment
There was a problem hiding this comment.
pretty much each line has a one for one replacement with the xcore custom option parser which is nice. the only note is the DCHECK was dropped, is it no longer necessary?
| op_data->max_classes_per_detection = m["max_classes_per_detection"].AsInt32(); | ||
| if (m["detections_per_class"].IsNull()) | ||
| auto* op_data = | ||
| ops::micro::xcore::construct_persistent_object<OpData>(context); |
There was a problem hiding this comment.
does this not need/benefit from TFLITE_DCHECK?
Author
There was a problem hiding this comment.
context->AllocatePersistentBuffer should not be nullptr (if it is, it means the function pointer has not been registered, not sure how that would happen). I'll add a check inside construct_persistent_object to make sure the memory request is succesful.
andrewstanfordjason
approved these changes
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.