Repository navigation
feat: remove setPlaceholderKeys - #1105
Merged
Merged
Conversation
Do no add `undefined` properties in parsed result object for options absent from provided `argv`. BREAKING CHANGE: Options absent from `argv` (not set via CLI argument) are now absent from the parsed result object rather tahn being set with `undefined`
Member
|
@pvdlg mind trying |
Contributor
Author
|
Yes, it works as expected! Thanks! |
Contributor
Author
|
Don't you want to include a version of |
Member
|
@pvdlg done, and published to |
Contributor
Author
|
Awesome, thanks! |
eliperelman
referenced
this pull request
in neutrinojs/neutrino
Jul 2, 2018
This Pull Request updates dependency [yargs](https://github.com/yargs/yargs) from `^11.0.0` to `^12.0.0` <details> <summary>Release Notes</summary> ### [`v12.0.1`](https://github.com/yargs/yargs/blob/master/CHANGELOG.md#​1201httpsgithubcomyargsyargscomparev1200v1201-2018-06-29) [Compare Source](yargs/yargs@v12.0.0...v12.0.1) #### [12.0.1](yargs/yargs@v12.0.0...v12.0.1) (2018-06-29) --- ### [`v12.0.0`](https://github.com/yargs/yargs/blob/master/CHANGELOG.md#​1200httpsgithubcomyargsyargscomparev1110v1200-2018-06-26) [Compare Source](yargs/yargs@v11.1.0...v12.0.0) ##### Bug Fixes * .argv and .parse() now invoke identical code path ([#​1126](`https://github.com/yargs/yargs/issues/1126`)) ([f13ebf4](yargs/yargs@f13ebf4)) * remove the trailing white spaces from the help output ([#​1090](`https://github.com/yargs/yargs/issues/1090`)) ([3f0746c](yargs/yargs@3f0746c)) * **completion:** Avoid default command and recommendations during completion ([#​1123](`https://github.com/yargs/yargs/issues/1123`)) ([036e7c5](yargs/yargs@036e7c5)) ##### Chores * test Node.js 6, 8 and 10 ([#​1160](`https://github.com/yargs/yargs/issues/1160`)) ([84f9d2b](yargs/yargs@84f9d2b)) * upgrade to version of yargs-parser that does not populate value for unset boolean ([#​1104](`https://github.com/yargs/yargs/issues/1104`)) ([d4705f4](yargs/yargs@d4705f4)) ##### Features * add support for global middleware, useful for shared tasks like metrics ([#​1119](`https://github.com/yargs/yargs/issues/1119`)) ([9d71ac7](yargs/yargs@9d71ac7)) * allow setting scriptName $0 ([#​1143](`https://github.com/yargs/yargs/issues/1143`)) ([a2f2eae](yargs/yargs@a2f2eae)) * remove `setPlaceholderKeys` ([#​1105](`https://github.com/yargs/yargs/issues/1105`)) ([6ee2c82](yargs/yargs@6ee2c82)) ##### BREAKING CHANGES * Options absent from `argv` (not set via CLI argument) are now absent from the parsed result object rather than being set with `undefined` * drop Node 4 from testing matrix, such that we'll gradually start drifting away from supporting Node 4. * yargs-parser does not populate 'false' when boolean flag is not passed * tests that assert against help output will need to be updated --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1071
Do no add
undefinedproperties in parsed result object for options absent from providedargv.BREAKING CHANGE: Options absent from
argv(not set via CLI argument) are now absent from the parsed result object rather tahn being set withundefined