Skip to content

runMigrationSilently doesn’t work #640

Closed

Description

@Profpatsch

On my linux machine runMigrationSilently just returns an empty lists and still prints everything to <wherever I log it>.

The code uses capture_ from silently, which tries to capture a handle output, writes it to a temp file and reads that file back again. That’s quite a brittle hack! And probably completely unnecessary …

Activity

  1. gregwebs commented on Dec 18, 2016

    @gregwebs
    Member

    I presume you mean runMigrationSilent. I don't know how it could return an empty list if there was a migration to apply.

    Do you want this function to be deprecated?

  2. Profpatsch commented on Dec 19, 2016

    @Profpatsch
    Author

    I think it’s a good function to have, but it should not try to capture from the output handle, rather use internal data structures and return them instead of printing.

  3. parsonsmatt commented on Oct 11, 2019

    @parsonsmatt
    Collaborator

    Fixed by #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions