adding `upsertWhere` and `upsertManyWhere` to `persistent-postgresql` by dmarticus · Pull Request #1222 · yesodweb/persistent

dmarticus · 2021-03-31T18:40:39Z

Before submitting your PR, check that you've:

Documented new APIs with Haddock markup
Added @since declarations to the Haddock

After submitting your PR:

Update the Changelog.md file with a link to your PR
Bumped the version number if there isn't an (unreleased) on the Changelog
Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

…sh :)

Co-authored-by: Matt Parsons <[email protected]>

…ffedback

parsonsmatt · 2021-04-06T21:58:03Z

+--
+-- -- @since 2.12.1.0
+upsertManyWhere ::
+  forall record backend m.


so the project does use 4 space indentation - could you get that done?

(on master I've created .editorconfig and .stylish-haskell.yaml files which will help make that easier)

oh my bad, I tried running stylish-haskell before pushing; I'll try again.

stylish-haskell won't do formatting changes like that :\ It's fine to leave as-is, it can ge trefactored later.

OH good to know

parsonsmatt · 2021-04-06T23:11:37Z

+{-# LANGUAGE OverloadedStrings #-}
+
+module Database.Persist.Postgresql.Util (
+  mkPostgresUpdateText


Since this module only has one function, let's just put it directly in Database.Persist.Postgresql

Co-authored-by: Matt Parsons <[email protected]>

parsonsmatt · 2021-04-06T23:49:52Z

+--
+-- -- @since 2.12.1.0
+upsertManyWhere ::
+  forall record backend m.


stylish-haskell won't do formatting changes like that :\ It's fine to leave as-is, it can ge trefactored later.

Co-authored-by: Matt Parsons <[email protected]>

…k of what we have

dmarticus · 2021-04-07T19:44:57Z

+-- `upsertManyWhere`
+--
+-- @since 2.12.1.0
+-- TODO: we could probably make a sum type for the `Filter` record that's passed into the `upserWhere` and


@parsonsmatt does this TODO say enough/make sense?

dmarticus · 2021-04-08T17:42:21Z

@parsonsmatt did I address all the changes needed?

parsonsmatt · 2021-04-08T18:49:08Z

+-- `upsertManyWhere`
+--
+-- @since 2.12.1.0
+-- TODO: we could probably make a sum type for the `Filter` record that's passed into the `upserWhere` and


dmarticus added 4 commits March 31, 2021 11:15

initial implementation of the upsertWhere

4e4903d

whoops don't commit that

f61f33f

don't export this

767ed39

updating docs and changelog

e49750e

dmarticus changed the title ~~Mer 676~~ adding upsertWhere and upsertManyWhere Mar 31, 2021

dmarticus marked this pull request as draft March 31, 2021 21:29

remove redundant code

95d4b0c

dmarticus commented Mar 31, 2021

View reviewed changes

omg hls led me astray

8db67bb

dmarticus commented Mar 31, 2021

View reviewed changes

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Outdated

dmarticus commented Mar 31, 2021

View reviewed changes

Comment thread persistent/Database/Persist/Sql/Orphan/PersistQuery.hs

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Outdated

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs

dmarticus marked this pull request as ready for review March 31, 2021 22:02

dmarticus changed the title ~~adding upsertWhere and upsertManyWhere~~ adding upsertWhere and upsertManyWhere to persistent-postgresql Apr 1, 2021

dmarticus added 3 commits March 31, 2021 20:41

refactoring the connection, updating the changelog, and running styli…

85a442d

…sh :)

continue on errors

36c2446

put it in the wrong place i don't actually know yaml

c7630a5

parsonsmatt reviewed Apr 1, 2021

View reviewed changes

Comment thread .github/workflows/haskell.yml Outdated

dmarticus added 3 commits April 1, 2021 10:42

jeez maybe this works

7d6af72

maybe it should go here instead

27d9edb

test this on CI

a7ed10f

parsonsmatt reviewed Apr 1, 2021

View reviewed changes

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs

dmarticus added 3 commits April 1, 2021 14:20

testing a different DB

12cecff

preparing for the PR

1d5af15

yikes idk what i updated these haddocks incorrectly

eed0a8a

dmarticus commented Apr 5, 2021

View reviewed changes

parsonsmatt reviewed Apr 5, 2021

View reviewed changes

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Outdated

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Outdated

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Outdated

Comment thread persistent-postgresql/test/UpsertWhere.hs

Update persistent-postgresql/Database/Persist/Postgresql.hs

f9c9015

Co-authored-by: Matt Parsons <[email protected]>

parsonsmatt reviewed Apr 5, 2021

View reviewed changes

Comment thread persistent-postgresql/test/UpsertWhere.hs

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Outdated

dmarticus added 2 commits April 5, 2021 11:15

moving a postgres-specific util to its own module, other code review …

495b609

…ffedback

one last test is failing but I'd love external input on why

81cf7b0

dmarticus added 4 commits April 5, 2021 17:37

generalized the postgresql changes to PersistQuery

82b56c5

finished implementation, added more tests, removed all todos

b9fdc8c

haddock update

f5c40e1

finishing the rest of the haddocks

22cdeb6

dmarticus commented Apr 6, 2021

View reviewed changes

Comment thread persistent/Database/Persist/Sql/Orphan/PersistQuery.hs Outdated

don't need to touch Raw

bb05bfe

parsonsmatt reviewed Apr 6, 2021

View reviewed changes

Comment thread persistent/Database/Persist/Sql/Orphan/PersistQuery.hs Outdated

Comment thread persistent/Database/Persist/Sql/Orphan/PersistQuery.hs Outdated

remodeled the data

365b1b4

parsonsmatt requested changes Apr 6, 2021

View reviewed changes

dmarticus and others added 2 commits April 6, 2021 16:31

Update persistent-postgresql/Database/Persist/Postgresql.hs

078ae4d

Co-authored-by: Matt Parsons <[email protected]>

Update persistent-postgresql/Database/Persist/Postgresql.hs

a75421a

Co-authored-by: Matt Parsons <[email protected]>

parsonsmatt reviewed Apr 6, 2021

View reviewed changes

dmarticus and others added 7 commits April 6, 2021 17:01

Update persistent-postgresql/Database/Persist/Postgresql.hs

84bcb35

Co-authored-by: Matt Parsons <[email protected]>

fix formatting

ace0569

latest changes real quick

de8f077

this should all compile but there's no sum type yet. Just taking stoc…

b8676f9

…k of what we have

remove debug logs

b894059

add sum type todo

83f3648

this should work

fed25a9

dmarticus commented Apr 7, 2021

View reviewed changes

parsonsmatt reviewed Apr 7, 2021

View reviewed changes

Comment thread persistent-postgresql/test/UpsertWhere.hs

Comment thread persistent-postgresql/test/UpsertWhere.hs Outdated

dmarticus added 5 commits April 7, 2021 15:04

we got the tests rocking!

6420304

add an assertion to the mysql test

cc750ec

ooops gotta update the mysql test to make it correct

ae9d88a

omg DERP

4d5e689

updating tests and also re-running CI

b5b0c78

parsonsmatt approved these changes Apr 8, 2021

View reviewed changes

parsonsmatt merged commit 9f25cb8 into yesodweb:master Apr 8, 2021

dmarticus mentioned this pull request Apr 14, 2021

Fix formatting for upsertManyWhere haddock #1227

Closed

Conversation

dmarticus commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmarticus commented Apr 8, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dmarticus commented Mar 31, 2021 •

edited

Loading