Skip to content

Support aeson-2 and template-haskell-2.18 (ghc-9.2.1) - #1335

Closed
ruomad wants to merge 4 commits into
yesodweb:masterfrom
ruomad:master
Closed

Support aeson-2 and template-haskell-2.18 (ghc-9.2.1)#1335
ruomad wants to merge 4 commits into
yesodweb:masterfrom
ruomad:master

Conversation

@ruomad

@ruomad ruomad commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Tentative patch to

support aeson-2 (introducing Key/KeyMap as an abstraction in replacement to HashMap Text Value)
support template-haskell-2.18.0 (changes the type of some functions, esp. ConP)
which makes it possible to compile with ghc-9.2.1

(cleaner version, sorry for the noise)

ruomad added 4 commits November 4, 2021 01:01
@ruomad
Adapt to aeson-2
9b8ac5f
@ruomad
Adapt to aeson-2
60ebada
@ruomad
Adapt to aeson-2
887f9ac
@ruomad
Adapt to template-haskell-2.18.0
29a9cbe 
Another solution would be to use the template-haskell-compat-v0208
@ruomad

ruomad commented Nov 4, 2021

Copy link
Copy Markdown
Contributor Author

Hum, I don.t know why this fails… the log is not very helpful

@parsonsmatt

parsonsmatt commented Nov 4, 2021

Copy link
Copy Markdown
Collaborator

It's a problem with persistent-mongoDB - relevant log line

@ruomad

ruomad commented Nov 5, 2021

Copy link
Copy Markdown
Contributor Author

Well, OK.
I indeed only use (and build) persistent-postgresql, so I'll have to take a look to other persistent modules as well.
I was supposing the specific modules were not affected by internal changes in aeson/persistent core.

@brandon-leapyear

brandon-leapyear commented Nov 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

I believe Database.Persist.TH is still failing. I think it's this line:

persistent/persistent/Database/Persist/TH.hs

Line 2673 in 29a9cbe

(Just (packE `AppE` LitE (StringL $ unpack $ unFieldNameHS $ unboundFieldNameHS f)))

This is still using Text.pack for a Key.

@brandon-leapyear brandon-leapyear mentioned this pull request Nov 15, 2021
Closed
@brandon-leapyear

brandon-leapyear commented Nov 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

Forked here: #1338. Feel free to merge/cherry-pick back

@bergmark bergmark mentioned this pull request Nov 28, 2021
Merged
@bergmark bergmark mentioned this pull request Jan 15, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ruomad @parsonsmatt @brandon-leapyear