Repository navigation
NFData PersistValue - #1440
Merged
parsonsmatt merged 3 commits intoDec 3, 2022
Merged
NFData PersistValue#1440
Conversation
dustin
approved these changes
Nov 17, 2022
parsonsmatt
reviewed
Nov 17, 2022
parsonsmatt
left a comment
parsonsmatt
left a comment
Collaborator
There was a problem hiding this comment.
Please add the changelog and version bump and I'll have it released soon
thanks!
Contributor
Author
Awesome! Changelog updated and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully evaluating a
PersistValueis important for gathering correct metrics. E.g. to get an accurate estimation of how long the SQL itself takes to run, it's essential to force the[PersistValue]which is used to construct the statement before starting the timer.