Skip to content

Make use of CautiousMigration type alias in SQL backends. - #1459

Merged
parsonsmatt merged 1 commit into
yesodweb:masterfrom
arrowd:CautiousMigration
Jan 22, 2023
Merged

parsonsmatt merged 1 commit into
yesodweb:masterfrom
arrowd:CautiousMigration

Conversation

@arrowd

@arrowd arrowd commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

When reading migrate' implementations of persistent-sqlite and persistent-postgresql it took me a while to figure out what (Bool, Text) actually means. Using the type alias from Database.Persist.Sql.Migration makes it clearer.

@arrowd

arrowd commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Bump. This PR is trivial, can we get it merged in?

@parsonsmatt

Copy link
Copy Markdown
Collaborator

sure! please update the changelog, bump the version bound, and I'll prepare a release.

@arrowd
arrowd force-pushed the CautiousMigration branch from 33dceef to 0d93670 Compare January 12, 2023 19:25
@arrowd

arrowd commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Ouch, I should've bumped backend packages, not persistent itself, right?

@parsonsmatt

Copy link
Copy Markdown
Collaborator

Yup - persistent only gets a changelog/bump when it changes. I don't want to keep everything in lock step.

* Bump persistent-mysql, persistent-postgresql and persistent-sqlite versions.

* Update respective changelogs.
@arrowd
arrowd force-pushed the CautiousMigration branch from 0d93670 to 978c4f0 Compare January 12, 2023 19:46
@arrowd

arrowd commented Jan 17, 2023

Copy link
Copy Markdown
Contributor Author

Another bump.

@arrowd

arrowd commented Jan 22, 2023

Copy link
Copy Markdown
Contributor Author

It is disappointing to see such trivial PR taking so long to get in. I have other small changes in queue that I'm hoping to upstream.

@parsonsmatt

Copy link
Copy Markdown
Collaborator

I understand your frustration. My work and personal situation do not leave much time or energy for OSS maintenance right now.

With this PR merged, your future PRs should automatically have CI run for them, which will speed things up a good bit.

For future PRs, please don't delete the PR template.

@parsonsmatt
parsonsmatt merged commit 6fdbf84 into yesodweb:master Jan 22, 2023
@arrowd

arrowd commented Jan 22, 2023

Copy link
Copy Markdown
Contributor Author

I understand your frustration. My work and personal situation do not leave much time or energy for OSS maintenance right now.

Yes, we're all volunteers here. I appreciate the time you took for this review.

With this PR merged, your future PRs should automatically have CI run for them, which will speed things up a good bit.

For future PRs, please don't delete the PR template.

Ok, noted. Thanks!

@arrowd
arrowd deleted the CautiousMigration branch January 22, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants