Repository navigation
persistent-postgresql: add createPostgresqlPoolTailored function - #1511
Merged
Merged
Conversation
This change adds a connection pool creation function that is just like the `createPostgresqlPoolModifiedWithVersion` function but that can take a custom `open'`-like connection-creation function. The motivation for this change is that we need to be able to customize the resource creation action dynamically at run-time.
This change alters the API surface (via addition) and, as-per `CONTRIBUTING.md`, requires a `C` bump.
... so that users can construct their own `open'`-like function.
... so users don't have to write their own.
ixmatus
force-pushed
the
parnell/custom-mkconn
branch
from
August 8, 2023 00:05
75355e4 to
9788fad
Compare
parsonsmatt
approved these changes
Sep 7, 2023
parsonsmatt
left a comment
parsonsmatt
left a comment
Collaborator
There was a problem hiding this comment.
Seems reasonable to me, though I do think the panoply of creation functions is getting a bit out of hand. I'll make a followup issue to refactor this and make an interface exposing a datatype-of-functions for these hooks.
Collaborator
|
Can you repush to trigger CI? Not sure why it isn't going |
As requested by @parsonsmatt.
Contributor
Author
|
@parsonsmatt I just re-pushed but that looks like it didn't trigger CI. |
Collaborator
|
Sorry for the delay - released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a connection pool creation function that is just like the
createPostgresqlPoolModifiedWithVersionfunction but that can take a customopen'-like connection-creation function.The motivation for this change is that we need to be able to customize the resource creation action dynamically at run-time.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog