Deprecate x-extensible-enum - #837
Conversation
invalid team IDThe team ID in your You can follow this guideline for help. |
2 similar comments
invalid team IDThe team ID in your You can follow this guideline for help. |
invalid team IDThe team ID in your You can follow this guideline for help. |
tfrauenstein
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR -- LGTM!
I provided some (mostly editorial) change proposals.
There are other occurrences of x-extensible-enum in the following rules that need to be updated:
The Event Type specification: rule #197 also uses x-extensible-enum. However, the rule anyway needs to be cleaned-up -- see Issue: Optimize the Event Guidelines for its usage with Nakadi. So I propose to handle this via a separate PR for the Event Guideline Clean-Up issue.
Additionally, I propose to add a log entry to the Change History.
|
@ePaul I just discovered that 'examples' in OpenAPI 3.0 is not yet consistent with JSON Schema -- this was only fixed with OpenAPI 3.1! In OpenAPI 3.0 |
|
As OpenAPI 3.0 doesn't have |
invalid team IDThe team ID in your (If this PR is already fixing this, ignore the warning. But preferably fix it You can follow this guideline for help. |
Implements #831.
Co-authored-by: Thomas Frauenstein <[email protected]>
c1e8eb1 to
c02f13c
Compare
|
I've applied some of the editorial suggestions and made a few more of my own, also indicating the relation to OpenAPI 3.1. |
| Previously (until May 2025), this guideline recommended our own proprietary | ||
| {x-extensible-enum} JSON schema extension here, with a similar semantic: | ||
|
|
||
| > This is the *complete* list of values *currently* possible, but consumers must be |
There was a problem hiding this comment.
Yes, I would remove it to avoid redundancies in the same rule context. I also would replace 'similar semantic' by 'same semantics'.
editorial: comma, word order Co-authored-by: Thomas Frauenstein <[email protected]>
Co-authored-by: Thomas Frauenstein <[email protected]>
Co-authored-by: Paŭlo Ebermann <[email protected]>
|
👍 |
|
👍 |
1 similar comment
|
👍 |
Implements #831.
Also some minor changes to clarify things elsewhere.