Repository navigation
Fix last_n keep rule (#691) - #750
Merged
Merged
Conversation
Fron zrepl/zrepl#691 The last_n prune rule keeps everything, regardless of if it matches the regex or not, if there are less than count snapshot. The expectation would be to never keep non-regex snapshots, regardless of number.
problame
requested changes
Oct 31, 2023
problame
left a comment
problame
left a comment
Member
There was a problem hiding this comment.
Thanks for this contribution, and sorry for the late reply!
This PR is correct, and in line what the docs always said.
Usually with this kind of change there's risk about existing setups relying on the bug, but, with this one, I can't see a problem. So, let's just fix it.
I'd love for more tet coverage. Can you add ad additional test case that fails without this PR and works with this PR?
Contributor
Author
Already done. This line MustKeepLastN(4, "a")tests it. |
Member
|
Thanks again, and sorry for the long delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #691
The last_n prune rule keeps everything, regardless of if it matches the regex or not, if there are less than count snapshot. The expectation would be to never keep non-regex snapshots, regardless of number.