Repository navigation
Allow same root_fs for different jobs: sinks and so on - #752
Merged
Merged
Conversation
The idea of this check is ``` // idea: // no path in rfss must be prefix of another ``` Technically, with two equal root_fs, one of them is really prefix of other. But logically, and I think we need exactly this, a prefix is a part of some string. So two equal root_fs are not a prefix of each other. And I don't see any reason why we can't have jobs with same root_fs. Anyway we are root_fs + client's name, so names of datasets never are never overlapping.
It isn't compatible with pull jobs, because puul jobs don't add client identities to their root_fs. This reverts commit 3a4d546.
Because some jobs add client identity to root_fs and other jobs don't do that,
we can't reliable detect overlapping of filesystems. And and the same time we
need an ability to use equal or overlapped root_fs for different jobs. For
instance see this config:
```
- name: "zdisk"
type: "sink"
root_fs: "zdisk/zrepl"
serve:
type: "local"
listener_name: "zdisk"
```
and
```
- name: "remote-to-zdisk"
type: "pull"
connect:
type: "tls"
root_fs: "zdisk/zrepl/remote"
```
As you can see, two jobs have overlapped root_fs, but actually datasets are not
overlapped, because job `zdisk` save everything under `zdisk/zrepl/localhost`,
because it adds client identity. So they actually use two different filesystems:
`zdisk/zrepl/localhost` and `zdisk/zrepl/remote`. And we can't detect this
situation during config check. So let's just remove this check, because it's
admin's duty to configure correct root_fs's.
problame
enabled auto-merge (squash)
October 31, 2023 21:41
problame
disabled auto-merge
October 31, 2023 23:05
Member
|
Will merge this after #763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because some jobs add client identity to root_fs and other jobs don't do that,
we can't reliable detect overlapping of filesystems. And and the same time we
need an ability to use equal or overlapped root_fs for different jobs. For
instance see this config:
and
As you can see, two jobs have overlapped root_fs, but actually datasets are not
overlapped, because job
zdisksave everything underzdisk/zrepl/localhost,because it adds client identity. So they actually use two different filesystems:
zdisk/zrepl/localhostandzdisk/zrepl/remote. And we can't detect thissituation during config check. So let's just remove this check, because it's
admin's duty to configure correct root_fs's.