Details
- Reviewers
• jorendorff - Commits
- rMOZILLACENTRALa5323b1391bf: Bug 1689499 - Replace GetAsyncCycleRoot with [[CycleRoot]] field;r=jorendorff
rMOZILLACENTRALb42024c79b4c: Bug 1689499 - Replace GetAsyncCycleRoot with [[CycleRoot]] field;r=jorendorff
rMOZILLACENTRAL6ae5b3c665fd: Bug 1689499 - Replace GetAsyncCycleRoot with [[CycleRoot]] field;r=jorendorff - Bugzilla Bug ID
- 1689499
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Build Status
Buildable 293129 Build 386275: arc lint + arc unit
Event Timeline
Code analysis found 2 defects in the diff 394087:
- 2 defects found by clang-format
You can run this analysis locally with:
- ./mach clang-format -s -p js/src/vm/SelfHosting.cpp js/src/builtin/ModuleObject.h (C/C++)
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
Code analysis found 1 defect in the diff 395892:
- 1 defect found by clang-format
You can run this analysis locally with:
- ./mach clang-format -s -p js/src/vm/SelfHosting.cpp (C/C++)
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
A test is in a prior patch.
| js/src/builtin/ModuleObject.cpp | ||
|---|---|---|
| 1041 | This is undefined behavior if the slot was not previously set. The proposal doesn't make it clear that [[CycleRoot]] is always set when a module becomes evaluated, or what other criterion, if any, establishes that [[CycleRoot]] has been set. If it did, the assertion inside .toObject() would be enough for me. But since I can't tell what's going on, please MOZ_RELEASE_ASSERT here that the slot value .isObject(). Defensive coding. | |