Repository navigation
Implement identity on SimpleUser and UnauthenticatedUser - #3271
Merged
Merged
Conversation
…authenticatedUser BaseUser defined identity as abstract but neither concrete subclass implemented it, causing NotImplementedError at runtime. - SimpleUser.identity returns username - UnauthenticatedUser.identity returns ""
Kludex
changed the title
identity on SimpleUser and UnauthenticatedUser
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/authentication.md">
<violation number="1">
P2: `BaseUser` defines three abstract properties (`is_authenticated`, `display_name`, and `identity`), all raising `NotImplementedError`, but the new docs text says it "provides two properties" and lists only the first two. Since `identity` was just implemented on the built-in users, a user subclass that follows these docs and omits `identity` will hit `NotImplementedError` at runtime — the exact failure this PR fixes. Restore `.identity` to the list and say "three properties".</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Kludex
approved these changes
Sep 7, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(authentication): implement identity property on SimpleUser and UnauthenticatedUser
BaseUser defined identity as abstract but neither concrete subclass implemented it, causing NotImplementedError at runtime.
Summary
BaseUser defines identity as an abstract property (raises NotImplementedError).
Neither SimpleUser nor UnauthenticatedUser implement it.
Discussion
Checklist