Repository navigation
Add excluded_urls to OpenTelemetryMiddleware - #3463
Conversation
|
Docs preview: https://59462f4d-starlette.marcelotryle.workers.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d4f7dea7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merging this PR will degrade performance by 20.24%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | test_multipart[file-512KiB] |
3.4 ms | 4.3 ms | -20.24% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing add-opentelemetry-excluded-urls (e5d9445) with main (3b0bc1d)
|
The branch includes the benchmark normalization from #3464, and I reran its benchmark job. CodSpeed still reports one unrelated multipart regression while comparing an AMD EPYC 7763 runner against an Intel Xeon Platinum 8370C runner. The branch diff only contains OpenTelemetry middleware, tests, and documentation, so there is no source change to make; this result needs to be acknowledged as infrastructure noise. |
Kludex
changed the title
exclude_urls to OpenTelemetryMiddleware
This reverts commit d72dd54.
Kludex
changed the title
exclude_urls to OpenTelemetryMiddlewareexcluded_urls to OpenTelemetryMiddleware
This branch was successfully deployed
1 participant
Summary
excluded_urlsparameter toOpenTelemetryMiddlewareValidation
./scripts/checkuv run pytest tests/middleware/test_opentelemetry.pyAI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.