Repository navigation
Accept collections in CORS configuration annotations - #3518
Merged
Merged
Conversation
Co-authored-by: Kamil Monicz <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Docs preview: https://89f6a9fe-starlette.marcelotryle.workers.dev |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Merging this PR will degrade performance by 10.83%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
Co-authored-by: Kamil Monicz <[email protected]>
Co-authored-by: Kamil Monicz <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORSMiddlewarealready accepts sets and frozensets at runtime, but itsSequence[str]annotations reject them during type checking. UseCollection[str]forallow_origins,allow_methods,allow_headers, andexpose_headersso the annotations describe the operations the middleware needs.Existing list and tuple arguments remain accepted. Runtime logic and immutable tuple defaults are unchanged.
Validation: all 36 existing CORS tests and mypy pass.
Extracted from @Zaczero's work in #3067. Co-authored by Kamil Monicz (@Zaczero).
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.