Nested one-liners broken with md_in_html #1074

Activity

1. git1sal commented on Nov 23, 2020

   

   git1sal

   on Nov 23, 2020

   Author

   More actions

   Oh, I should have mentioned also that the actual content *foo* does not get markdownized in this test case.
2. waylan commented on Nov 23, 2020

   

   waylan

   on Nov 23, 2020

   Last edited by waylan

   Member

   More actions

   I'm not able to replicate that behavior in any recent version. With versions 3.3.0 through 3.3.3 I get:

   <div class="outer">
   <div class="inner">
   <p><em>foo</em></p>
   </div>
   </div>

   However, I see that in #1069 (which is part of the unreleased version 3.3.4) we broke this and I am getting:

   <div class="outer">
   <p><div class="inner" markdown="block"><em>foo</em></p>
   </div>
   </div>

   That does not turn things 'inside-out,' but it is clearly wrong. and it demonstrates again that our tests for md_in_html are incomplete.

   By the way, there is a clear difference between the inputs:

   <div class="outer" markdown="block">
   <div class="inner" markdown="block">*foo*</div>
   </div>
   

   ... which works fine and ...

   <div class="outer" markdown="block"><div class="inner" markdown="block">*foo*</div></div>
   

   ... which is broken in the current HEAD of master. The later input is also not something we have in our tests.

   The issue is that the nested div does not start at the beginning of a line and therefore is not parsed as a block level element. Under normal circumstances, this would be the correct behavior. However, as it is the first and immediate child of the outer <div> is should still be treated as a block level element. Interestingly, when working on #1069 it occurred to me that this could be an issue, but when the simple fix didn't break any tests, I dismissed the thought. I think we need a more sophisticated manner to determine at_line_start. Sigh.
3. waylan

   changed the title [-]Hierarchy of nested <div markdown=1> gets turned inside-out[/-] [+]Nested one-liners broken with md_in_html[/+] on Nov 23, 2020
4. waylan

   added

   bugBug report.Bug report.

   confirmedConfirmed bug report or approved feature request.Confirmed bug report or approved feature request.

   extensionRelated to one or more of the included extensions.Related to one or more of the included extensions.

   on Nov 23, 2020
5. git1sal commented on Nov 24, 2020

   

   git1sal

   on Nov 24, 2020

   Author

   More actions

   Thank you very much—inserting newlines resolved the problem for me.

   Thank you for the amazing work you are doing on this package!
6. facelessuser

   added a commit that references this issue on Jan 25, 2025

   Better handling of one-liner Block HTML

   ...

   This issue will close once commit 08a4137 is merged into the 'master' branch.

   08a4137
7. facelessuser

   closed this as completedin #1503on Jan 28, 2025
8. facelessuser

   closed this as completedin f2ae4e4on Jan 28, 2025
9. facelessuser

   added a commit that references this issue on Jan 28, 2025

   Adjust `md_in_html` "markdown" blocks to process content consistently (…

   ...

   This issue will close once commit f2ae4e4 is merged into the 'master' branch.

   f2ae4e4