Repository navigation
[ty] Fix dict.pop overloads to accept arbitrary keys with defaults - #26241
Merged
Merged
Conversation
astral-sh-bot
Bot
changed the title
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 94.37%. The percentage of expected errors that received a diagnostic held steady at 89.00%. The number of fully passing files held steady at 94/134. |
charliermarsh
approved these changes
Jun 22, 2026
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
no-matching-overload |
0 | 13 | 0 |
invalid-method-override |
6 | 0 | 0 |
unused-type-ignore-comment |
2 | 0 | 0 |
| Total | 8 | 13 | 0 |
Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.
Raw diff (21 changes)
apprise (https://github.com/caronc/apprise)
- apprise/config/base.py:1273:21 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
beartype (https://github.com/beartype/beartype)
- beartype/_check/convert/_reduce/_pep/pep646/redpep484612646typearg.py:278:32 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/contrib/internal/ray/span_manager.py:244:21 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- ddtrace/contrib/internal/ray/span_manager.py:247:13 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
discord.py (https://github.com/Rapptz/discord.py)
+ discord/ui/view.py:986:64 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
django-stubs (https://github.com/typeddjango/django-stubs)
+ django-stubs/contrib/sessions/backends/base.pyi:38:9 error[invalid-method-override] Invalid override of method `pop`: Definition is incompatible with `dict.pop`
mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
+ bson/son.py:138:9 error[invalid-method-override] Invalid override of method `pop`: Definition is incompatible with `dict.pop`
mypy (https://github.com/python/mypy)
+ mypy/typeshed/stdlib/collections/__init__.pyi:412:9 error[invalid-method-override] Invalid override of method `pop`: Definition is incompatible with `dict.pop`
pandas (https://github.com/pandas-dev/pandas)
- pandas/core/generic.py:3671:31 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- pandas/core/generic.py:3672:32 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
pwndbg (https://github.com/pwndbg/pwndbg)
- pwndbg/aglib/disasm/disassembly.py:91:5 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- pwndbg/aglib/disasm/disassembly.py:92:5 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
rotki (https://github.com/rotki/rotki)
- rotkehlchen/chain/aggregator.py:794:17 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- rotkehlchen/chain/aggregator.py:794:17 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- rotkehlchen/chain/aggregator.py:794:17 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- rotkehlchen/chain/aggregator.py:794:17 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
- rotkehlchen/chain/aggregator.py:794:17 error[no-matching-overload] No overload of bound method `dict.pop` matches arguments
+ rotkehlchen/chain/aggregator.py:988:50 warning[unused-type-ignore-comment] Unused blanket `type: ignore` directive
starlette (https://github.com/encode/starlette)
+ starlette/middleware/sessions.py:114:9 error[invalid-method-override] Invalid override of method `pop`: Definition is incompatible with `dict.pop`
werkzeug (https://github.com/pallets/werkzeug)
+ src/werkzeug/datastructures/mixins.py:271:9 error[invalid-method-override] Invalid override of method `pop`: Definition is incompatible with `dict.pop`
+ src/werkzeug/datastructures/structures.py:477:9 error[invalid-method-override] Invalid override of method `pop`: Definition is incompatible with `dict.pop`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust
dict.popoverloads in vendored typeshed so calls with a fallback value acceptobjectkeys, since those calls will never fail.Follow-up to #25831 - same principle applies.
Closes astral-sh/ty#3819
Testing
Added mdtests.