Skip to content

[ty] Avoid duplicate configuration error output - #26375

Merged
MichaReiser merged 1 commit into
mainfrom
micha/avoid-duplicate-config-errors
Jun 25, 2026
Merged

MichaReiser merged 1 commit into
mainfrom
micha/avoid-duplicate-config-errors

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jun 25, 2026 •

Copy link
Copy Markdown
Member

Summary

We iterate over the cause chain in ty's CLI. This prints the source of every error. However, we also have some error variants that print their own source.

This PR removes the inner source from the message. Because it will be added when printing the error chain.

Closes astral-sh/ty#3854

Test Plan

Updated tests

@astral-sh-bot astral-sh-bot Bot added the ty The ty type checker label Jun 25, 2026
@astral-sh-bot

astral-sh-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 94.47%. The percentage of expected errors that received a diagnostic held steady at 89.19%. The number of fully passing files held steady at 95/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@MichaReiser
MichaReiser force-pushed the micha/avoid-duplicate-config-errors branch from 531ef4f to 39489db Compare June 25, 2026 16:46
@MichaReiser MichaReiser added the bug An issue describing something that isn't working, or a PR that fixes a bug label Jun 25, 2026
@MichaReiser
MichaReiser marked this pull request as ready for review June 25, 2026 16:49
@MichaReiser
MichaReiser requested review from a team as code owners June 25, 2026 16:49
@astral-sh-bot
astral-sh-bot Bot requested a review from charliermarsh June 25, 2026 16:49
@MichaReiser
MichaReiser merged commit a56a774 into main Jun 25, 2026
63 checks passed
@MichaReiser
MichaReiser deleted the micha/avoid-duplicate-config-errors branch June 25, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue describing something that isn't working, or a PR that fixes a bug ty The ty type checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate error message

2 participants