Repository navigation
[ty] Highlight declarations in invalid-assignment diagnostics - #27872
Merged
Merged
Conversation
AlexWaygood
added
the
diagnostics
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 97.68%. The percentage of expected errors that received a diagnostic held steady at 93.44%. The number of fully passing files held steady at 109/136. |
Memory usage reportMemory usage unchanged ✅ |
|
| x: int = 1 | ||
|
|
||
| def assign() -> None: | ||
| nonlocal x |
Collaborator
There was a problem hiding this comment.
Worth testing global too?
Member
Author
There was a problem hiding this comment.
already tested a few lines above!
carljm
approved these changes
Aug 19, 2026
AlexWaygood
added a commit
that referenced
this pull request
Aug 19, 2026
(Stacked on top of #27872) ## Summary Add a disabled-by-default `unsound-assignment` rule for variable assignments whose inferred value is assignable to a fully static declared type but is not a subtype of it. Attribute and subscript assignments are deliberately excluded from this initial implementation. Share declaration lookup and diagnostic rendering with `invalid-assignment` so the rule points to the annotation responsible for the expected type, including parameters, variadics, global/nonlocal bindings, and augmented assignments. Fixes astral-sh/ty#4289.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an
invalid-assignmentdiagnostic is caused by a previously declared type, point directly to the annotation that established that type instead of only annotating the assignment target.Example