Deprecate spec and loose plugin options - #17972
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61532 |
|
commit: |
| if ("loose" in options) { | ||
| console.warn( | ||
| "@babel/plugin-transform-template-literals: The 'loose' option has been deprecated, " + | ||
| "use the `ignoreToPrimitiveHint` and `mutableTemplateObject` assumptions instead.", |
There was a problem hiding this comment.
| "use the `ignoreToPrimitiveHint` and `mutableTemplateObject` assumptions instead.", | |
| "use the `ignoreToPrimitiveHint` and `mutableTemplateObject` assumptions instead (https://babeljs.io/assumptions).", |
(and in all the others too)
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af53ab46e2
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
馃挕 Codex ReviewWhen users migrate When users migrate 鈩癸笍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
馃挕 Codex ReviewFor TypeScript users migrating from 鈩癸笍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
馃挕 Codex Reviewbabel/packages/babel-plugin-transform-arrow-functions/src/index.ts Lines 13 to 14 in d75542c When this warning is shown for 鈩癸笍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I'd like to merge this and release soon the next RC.
I think the above suggestion from codex is an improvement, the rest looks good.
JLHwung
left a comment
There was a problem hiding this comment.
Thank you.
A few wording fixes to indicate that privateFieldsAsProperties and privateFieldsAsSymbols are exclusive, and generally privateFieldsAsProperties should be preferred unless user run into specific shadowing issue.
Co-authored-by: Hu谩ng J霉nli脿ng <[email protected]>
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55fc4d0455
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Hu谩ng J霉nli脿ng <[email protected]>
Fixes #1, Fixes #2