Repository navigation
fix: assign closure body after handling return - #18193
Merged
Merged
Conversation
JLHwung
added
the
PR: Bug Fix 馃悰
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62024 |
|
commit: |
liuxingbaoyu
approved these changes
Aug 19, 2026
nicolo-ribaudo
approved these changes
Aug 25, 2026
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
Thanks for the detailed description :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of #18192 is data inconsistency: When
returnNum > 0, we wrap the return statement collected instate.returnswithin the{ v: ... }object wrapper. However, thestate.returnsis a NodePath collected at the start ofwrapLoopBody, while the emit output is from the loop body assigned to the loop closure body after the NodePath is collected: Therefore, changes to the NodePath here does not sync to the closure body and we see unwrapped return statement in the final output.The
wrapLoopBodyessentially moves the loop body to the loop closure body. To avoid duplicate nodes during the transform, we move the loop body reassigning step to the end of thewrapLoopBodytransform, in order to ensure that any AST changes in the loop body will be reflected on the loop closure.