Repository navigation
Update identifier definition to Unicode 18 - #18237
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62147 |
Contributor
Author
|
The CI error in the previous commit is expected, for whatever reasons the author of Acorn picked U+2B81E to construct an invalid identifier case: And Babel parser inherits Acorn's test suite and puts them under |
|
commit: |
nicolo-ribaudo
approved these changes
Sep 13, 2026
liuxingbaoyu
approved these changes
Sep 13, 2026
Contributor
U+2B81E has been assigned as a characger in Unicode 18. Change it to U+2FFFE, which guarantees to be a non-character code point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready for review. The Unicode 18 is scheduled to be released in the next week, when we can eventually merge this PR.