Skip to content

Support min_executions when listing tests - #372

Merged
meghan-kradolfer merged 1 commit into
mainfrom
te-6729-support-min_executions-when-listing-test-in-go-buildkite
Aug 26, 2026
Merged

meghan-kradolfer merged 1 commit into
mainfrom
te-6729-support-min_executions-when-listing-test-in-go-buildkite

Conversation

@meghan-kradolfer

@meghan-kradolfer meghan-kradolfer commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

Expose the Test Engine API's min_executions query parameter through TestsListOptions.

  • add MinExecutions to TestsListOptions
  • verify it is encoded as min_executions in list requests

Context

TE-6729

Verification

  • mise exec -- go test ./...

Rollback

Revert this PR. The change only adds an optional request parameter and its test coverage.

@meghan-kradolfer
meghan-kradolfer marked this pull request as ready for review August 26, 2026 22:37

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. This is an additive public SDK API change, so I'm leaving approval to a human reviewer.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 21579, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

About buildsworth

Model: gpt-5.6-sol with xhigh thinking.

How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.

Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant:

  • L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
  • L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
  • L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.

@meghan-kradolfer
meghan-kradolfer merged commit 4427dbd into main Aug 26, 2026
4 checks passed
@meghan-kradolfer
meghan-kradolfer deleted the te-6729-support-min_executions-when-listing-test-in-go-buildkite branch August 26, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants