Skip to content

[release/2.1] Fix erofs media type handling - #11855

Merged
AkihiroSuda merged 2 commits into
containerd:release/2.1from
k8s-infra-cherrypick-robot:cherry-pick-11851-to-release/2.1
May 16, 2025
Merged

AkihiroSuda merged 2 commits into
containerd:release/2.1from
k8s-infra-cherrypick-robot:cherry-pick-11851-to-release/2.1

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #11851

/assign hsiangkao

hsiangkao added 2 commits May 14, 2025 05:30
A dumb bug was just found after I worked out a usable native
converter [1], instead of relying on some prebuilt image..

[1] https://github.com/erofs/erofs-container-toolkit
Signed-off-by: Gao Xiang <[email protected]>
It's preferred to use `--sort=none` to avoid tar data twice due to
stricter data ordering.

Link: https://git.kernel.org/xiang/erofs-utils/c/e97530622872
Signed-off-by: Gao Xiang <[email protected]>
@k8s-ci-robot

Copy link
Copy Markdown

@k8s-infra-cherrypick-robot: GitHub didn't allow me to assign the following users: hsiangkao.

Note that only containerd members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

This is an automated cherry-pick of #11851

/assign hsiangkao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djdongjin

Copy link
Copy Markdown
Member

/ok-to-test

@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review May 15, 2025
@hsiangkao

hsiangkao commented May 16, 2025 •

Copy link
Copy Markdown
Member

/cc @dmcgowan @AkihiroSuda
(PTAL for this backport...)

@AkihiroSuda
AkihiroSuda merged commit 837aef0 into containerd:release/2.1 May 16, 2025
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review May 16, 2025
@dmcgowan dmcgowan added area/distribution Image Distribution area/storage Image Storage impact/changelog and removed area/distribution Image Distribution labels May 16, 2025
@dmcgowan dmcgowan changed the title [release/2.1] erofs-snapshotter: a fix for native image support and a performance tip [release/2.1] Fix erofs media type handling May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants