Skip to content

noxfile: mark pypy 3.11 as supported - #125

Merged
Julian merged 2 commits into
crate-py:mainfrom
marmoute:pypy3311
Mar 26, 2025
Merged

Julian merged 2 commits into
crate-py:mainfrom
marmoute:pypy3311

Conversation

@marmoute

@marmoute marmoute commented Mar 26, 2025 •

Copy link
Copy Markdown
Contributor

With pull request #123 merged, this compile with pypy3.11 fine.

This is rebased on top of #123 to have pyyp311 actually work.

Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.23.4 to 0.24.0.
- [Release notes](https://github.com/pyo3/pyo3/releases)
- [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md)
- [Commits](PyO3/pyo3@v0.23.4...v0.24.0)

---
updated-dependencies:
- dependency-name: pyo3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
With pull request crate-py#123 merged, this compile with pypy3.11 fine.
@mattip

mattip commented Mar 26, 2025

Copy link
Copy Markdown

CI is passing

@Julian

Julian commented Mar 26, 2025 •

Copy link
Copy Markdown
Member

Sorry, I meant to the CI build matrix's interpreters (e.g. here) so that we build wheels for it! But this is helpful too, thanks!

@Julian
Julian merged commit eee5ed6 into crate-py:main Mar 26, 2025
@Julian

Julian commented Mar 26, 2025

Copy link
Copy Markdown
Member

Building seems to fail still: https://github.com/crate-py/rpds/actions/runs/14083042178/job/39440334456

Help definitely still welcome @marmoute if those errors mean anything to you, otherwise I'll have to find some time to look at them more closely.

@marmoute

Copy link
Copy Markdown
Contributor Author

Building seems to fail still: https://github.com/crate-py/rpds/actions/runs/14083042178/job/39440334456

Help definitely still welcome @marmoute if those errors mean anything to you, otherwise I'll have to find some time to look at them more closely.

I am completly cluelss about these build, but double checking your patch, it seems like you have an extra comma in a space separated list pypy3.10, pypy3.11 in the first change to args: --release --out dist --interpreter.

@Julian

Julian commented Mar 26, 2025

Copy link
Copy Markdown
Member

Oh fun :/ indeed, thanks, let's see if that fixes it.

@Julian

Julian commented Mar 26, 2025

Copy link
Copy Markdown
Member

That got our errors down to one: https://github.com/crate-py/rpds/actions/runs/14084579529/job/39445373260 -- it seems the Windows build can't use PyPy3.11 even on x64, so I've re-removed it there as well. If that passes we're ready to go.

@marmoute

Copy link
Copy Markdown
Contributor Author

That got our errors down to one: https://github.com/crate-py/rpds/actions/runs/14084579529/job/39445373260 -- it seems the Windows build can't use PyPy3.11 even on x64, so I've re-removed it there as well. If that passes we're ready to go.

I don't care about Windows support here and I will let someone else take on this fight.

@mattip

mattip commented Mar 26, 2025

Copy link
Copy Markdown

That error is strange:

  --- stderr
  error: failed to generate python3.dll import library
  caused by:
    - 0: Unsupported PyPy version

What piece of the build does not support PyPy 3.11 on windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants