Repository navigation
fix: Restart a shut down worker before sending it a task. - #14015
Conversation
|
Hi @PeteTheHeat! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
PeteTheHeat
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
This seems reasonable to me, thanks! 👍 @phawxby thoughts? |
|
This looks good to me |
|
Thank you @PeteTheHeat and @SimenB! |
|
thank you indeed! ❤️ . Do we know if this is going to go in the next release? |
|
do we have any idea when this will be released? |
|
Whenever the next release is, I don't know what that cadence is. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Summary
This is a first attempt at trying to fix #13976.
The issue:
process.killlike the tests in this PR)WorkerPoolandFarmhave no idea one of the workers died, and tries to schedule more work on this worker.This PR:
Not sure if this is the best approach, open to feedback.
Test plan
yarn jest e2e/__tests__/workerRestartBeforeSend.test.tsBefore this PR, jest hangs forever. After, it completes.