Repository navigation
fix(jest-runtime): bind jest.isolateModulesAsync to this - #14083
Merged
Merged
Conversation
tjenkinson
force-pushed
the
fix-isolate-modules-async
branch
from
April 18, 2023 16:18
abd28ba to
e6c7f99
Compare
tjenkinson
marked this pull request as ready for review
April 18, 2023 16:27
tjenkinson
commented
Apr 18, 2023
| runtime.__mockRootPath, | ||
| 'ModuleWithState', | ||
| ); | ||
| expect(exports.getState()).toBe(1); |
Contributor
Author
There was a problem hiding this comment.
this would fail before
|
@tjenkinson I am currently facing this issue that any idea in which release this fix will be included? |
DmitryMakhnev
pushed a commit
to DmitryMakhnev/jest
that referenced
this pull request
May 5, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jest.isolateModulesAsynccurrently doesn't work asthisis not bound to the correct object.this._isolatedModuleRegistryon the actual instance doesn't get set soisolateModulesAsyncis essentially a no-op.Test plan
Added a new test that fails without the fix.