Skip to content

cherry-pick #9365 to v1.82.x - #9367

Merged
eshitachandwani merged 2 commits into
grpc:v1.82.xfrom
eshitachandwani:cpv1.82
Aug 25, 2026
Merged

eshitachandwani merged 2 commits into
grpc:v1.82.xfrom
eshitachandwani:cpv1.82

Conversation

@eshitachandwani

@eshitachandwani eshitachandwani commented Aug 25, 2026 •

Copy link
Copy Markdown
Member

Original PR : #9365

RELEASE NOTES:

  • server: Reject requests missing both :authority and Host headers with HTTP 400 and status Internal

…9365)

Fixes : grpc#9354

This PR updates the HTTP/2 transport layer to reject requests missing
both :authority and Host headers early. Also adds a defensive check in
xds server to ensure authority header is present.

RELEASE NOTES: 
- server: Reject requests missing both `:authority` and `Host` headers
with HTTP 400 and status `Internal`

---------

Co-authored-by: Madan Kumar <[email protected]>
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.42%. Comparing base (4bc2382) to head (7fccfec).

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.82.x    #9367      +/-   ##
===========================================
+ Coverage    87.39%   87.42%   +0.03%     
===========================================
  Files          418      418              
  Lines        28972    28978       +6     
===========================================
+ Hits         25319    25334      +15     
+ Misses        3653     3644       -9     
Files with missing lines Coverage Δ
internal/transport/http2_server.go 93.27% <100.00%> (+0.02%) ⬆️
internal/xds/server/routing.go 91.54% <100.00%> (+0.24%) ⬆️
test/servertester.go 75.00% <100.00%> (+0.89%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbissa mbissa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 5.1.0-0.nightly-2026-09-23-134227

@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 5.1.0-0.nightly-2026-09-29-061603

@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 5.1.0-0.nightly-2026-10-13-155450

@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 5.1.0-0.nightly-2026-10-14-011339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants