Skip to content

chore: set minimum TS version to v4.5 - #14542

Merged
SimenB merged 8 commits into
jestjs:mainfrom
SimenB:minimum-ts
Sep 19, 2023
Merged

SimenB merged 8 commits into
jestjs:mainfrom
SimenB:minimum-ts

Conversation

@SimenB

@SimenB SimenB commented Sep 18, 2023 •

Copy link
Copy Markdown
Member

@SimenB SimenB added this to the Jest 30 milestone Sep 18, 2023
@netlify

netlify Bot commented Sep 18, 2023 •

Copy link
Copy Markdown

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e4145f7
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65098429591519000807bea9
😎 Deploy Preview https://deploy-preview-14542--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB

SimenB commented Sep 19, 2023 •

Copy link
Copy Markdown
Member Author

Hmm, maybe 4.7 so we can use ESM at our leisure? Thoughts @mrazauskas?

EDIT: Or maybe even 5.0 for export type * as Types from './x';

@mrazauskas

Copy link
Copy Markdown
Contributor

I wanted to suggest 5.0 even before your edit showed up ;D

Can't find time for thinking about it deeper at the moment.

@SimenB

SimenB commented Sep 19, 2023

Copy link
Copy Markdown
Member Author

Sure, let's go for 5.0. It was released just over 6 months ago

@SimenB
SimenB enabled auto-merge (squash) September 19, 2023 10:04
@mrazauskas

Copy link
Copy Markdown
Contributor

@SimenB Would be good to update the title as well for commit message.

@SimenB
SimenB disabled auto-merge September 19, 2023 10:09
@SimenB
SimenB enabled auto-merge (squash) September 19, 2023 10:09
@SimenB

SimenB commented Sep 19, 2023

Copy link
Copy Markdown
Member Author

I've set the correct name in the auto merge

(macos queue is looooong, but this'll merge in a couple of hours or so. hopefully 😀)

@mrazauskas

Copy link
Copy Markdown
Contributor

I've set the correct name in the auto merge

Ah.. That’s smart. Invisible for the outside world (;

@SimenB
SimenB disabled auto-merge September 19, 2023 11:20
@SimenB
SimenB merged commit 9b7af03 into jestjs:main Sep 19, 2023
@SimenB
SimenB deleted the minimum-ts branch September 19, 2023 11:21
@SimenB

SimenB commented Sep 19, 2023

Copy link
Copy Markdown
Member Author

Hah - I aborted the auto merge since the queue is stupid long, and forgot to change when merging manually 🙈

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants