Repository navigation
fix: allow templating of null and undefined in a jest each key path template - #14831
Merged
SimenB merged 5 commits intoMar 16, 2024
Merged
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Germandrummer92
force-pushed
the
allow-templating-null-or-undefined
branch
from
February 6, 2024 14:00
5eb4ab8 to
6af8f19
Compare
Contributor
Author
|
hmm, not sure why the tests are now failing 😢 |
Germandrummer92
force-pushed
the
allow-templating-null-or-undefined
branch
from
March 5, 2024 17:56
6af8f19 to
c67c4bf
Compare
Member
|
The one failing test is a known one |
SimenB
approved these changes
Mar 8, 2024
SimenB
left a comment
SimenB
left a comment
Member
There was a problem hiding this comment.
thanks! just a minor change needed to actually run the test
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See newly added e2e tests, currently jest crashed with:
when adding a nested keypath as a template in a null or undefined object. Instead we just early-exit out of interplation in those cases.
Test plan
yarn testyarn constraints