Repository navigation
Move debug_stream initialization to helper method - #471
Merged
Merged
Conversation
kislyuk
requested changes
Jan 29, 2024
kislyuk
left a comment
kislyuk
left a comment
Owner
There was a problem hiding this comment.
Thanks. This looks good, except please do not try to edit Changes.rst manually, it is automatically generated. Can you please remove that change from the PR?
By default argcomplete tries to use fd 9 as its debug stream, but this could clash with something else trying to use the same file descriptor, for example a pytest plugin. Split into a _init_debug_stream() helper method which can now be overridden in subclasses.
Contributor
Author
|
Yep updated, got thrown off by the missing bullet point in the most recent entry :) |
kislyuk
approved these changes
Jan 29, 2024
Owner
|
Released in v3.2.3, please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default argcomplete tries to use fd 9 as its debug stream, but this could clash with something else trying to use the same file descriptor, for example a pytest plugin.
Split into a _init_debug_stream() helper method which can now be overridden in subclasses.
Closes #393