Repository navigation
Remove redundant guidance to read .env directly - #801
Merged
pushpak1300 merged 1 commit intoMay 12, 2026
Merged
pushpak1300 merged 1 commit into
pushpak1300 merged 1 commit into
Conversation
Member
|
Fair enough. can be removed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to the recent core-guideline cleanup work in #722 and #787 — the file reads cleanly. I'd like to propose removing one more redundant line: the instruction to read
.envdirectly to check environment variables.The line immediately above already documents
config:showand direct reads ofconfig/*.php, which cover the same use case. After tracing this through, the.envline looks redundant for legitimate lookups while pointing the model at a file Anthropic's secure-deployment guide and settings reference treat as a sensitive denylist target alongside~/.aws/credentialsand*.pem.I saw the prior discussion in #728 and agree with the response there: guideline text can't enforce access restrictions, that belongs in the agent's permission layer. This PR isn't trying to revisit that. It's a removal in the same spirit as #787, where a section was deleted once an adjacent mechanism made it redundant.
Behavior for users workflow is unchanged: agents can still read
.envfiles.