Repository navigation
[12.x] Use PDO subclass polyfill - #59640
Merged
Merged
Conversation
jnoordsij
marked this pull request as draft
April 10, 2026 16:44
jnoordsij
marked this pull request as ready for review
April 10, 2026 16:44
jnoordsij
marked this pull request as draft
April 10, 2026 16:44
jnoordsij
force-pushed
the
use-pdo-polyfill
branch
from
April 10, 2026 17:06
664c1bb to
f135a5b
Compare
crynobone
requested changes
Apr 13, 2026
crynobone
self-requested a review
April 13, 2026 04:50
crynobone
approved these changes
Apr 13, 2026
crynobone
marked this pull request as ready for review
April 13, 2026 04:55
Contributor
Author
|
Thanks for the bump @crynobone! |
jonagoldman
pushed a commit
to deplox/laravel-framework
that referenced
this pull request
Apr 30, 2026
* DRAFT: Bump symfony/polyfill-php8.4 to latest version * Simplify code by leveraging PDO subclass Symfony polyfill See also symfony/polyfill#549 * Apply suggestion from @crynobone * Apply suggestion from @crynobone --------- Co-authored-by: Mior Muhammad Zaki <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In symfony/polyfill#549 PDO subclass polyfills were introduced. These can be subsequently applied here to simplify code.
Note this is a draft until upstream tags a new version.Those interested in following this up elsewhere: https://github.com/search?q=org%3Alaravel+%5CPdo%5CMysql&type=code shows a list of occurences elsewhere that subsequently may be refactored in similar fashion.