Repository navigation
[13.x] Update SupportBinaryCodecTest - #61512
Merged
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
changed the title
jackbayliss
marked this pull request as ready for review
September 9, 2026 21:09
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 1, 2026
Add the deterministic incomplete UTF-8 sequence from upstream. Retain the existing regression proving that binary UUID bytes can also be valid UTF-8. Upstream: laravel/framework#61512 Framework source: 7068848dfe48fc3a433598e09ce798799d442a52. Documentation source: laravel/docs 13.x at ec28ad6ee78ebeada6095e05d33da7e8c42dd6dc. Validated with affected tests, repository formatting, full source and type-fixture analysis, and the full parallel test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flaked on me here https://github.com/laravel/framework/actions/runs/34403846162/job/102641947163?pr=61511#step:5:287
random_bytes(16) can actually return valid UTF8, so, this PR makes sure it doesn't flake
\xE3\x81is just part of a (japanese) byte sequence so, this always be true... (could argue we could remove it, but at least this covers more than 1 set)