Repository navigation
[13.x] Fix collapseWithKeys() crashing when the outer collection has string keys - #61539
Merged
taylorotwell merged 1 commit intoSep 11, 2026
Merged
Conversation
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 1, 2026
Handle string outer keys in collapseWithKeys and describe receiver types after collection mutation, including nullable keys. Return base collections for Eloquent duplicate attribute or callback values; keep model collections when no callback is supplied. Correct mapped duplicate and sum types, annotate empty builders and Wayfinder defaults, and preserve explicit null-key behavior without PHP 8.5 deprecations. Consolidate overlapping coverage. Collection tests and full type analysis pass. Upstream: laravel/framework#61539 laravel/framework#61571 laravel/framework#61572 laravel/framework#61578 laravel/framework#61597 laravel/framework#61611 laravel/framework#61621 Source: laravel/framework at 7068848dfe48fc3a433598e09ce798799d442a52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection::collapseWithKeys()throws when the outer collection has string keys, because the nested arrays are unpacked intoarray_replace()with their original keys, and PHP treats string keys in an unpacked array as named arguments:Mixing integer and string keys fails too, with
array_replace() does not accept unknown named parameters.Since the outer keys get thrown away anyway, I've changed it to collect the nested arrays into a plain list before passing them to
array_replace(). That's whatArr::collapse()already does. Collections with integer keys behave exactly as before.LazyCollection::collapseWithKeys()already handles string keys, so the new test runs against both implementations to keep them consistent.