Skip to content

Fix( Issue #1073): Bug fix for the issue with mocking value classes with coEvery - #1332

Merged
Raibaz merged 3 commits into
mockk:masterfrom
kpadhiamex:1073-fix-issue-with-mocking-value-classes-with-coEvery
Jan 4, 2025
Merged

Raibaz merged 3 commits into
mockk:masterfrom
kpadhiamex:1073-fix-issue-with-mocking-value-classes-with-coEvery

Conversation

@kpadhiamex

Copy link
Copy Markdown

Fix( Issue #1073): Bug fix for the issue with mocking value classes with coEvery.
Enable few disabled tests for support nested value classes (issue: 859)

…ses with coEvery.

Enable few disabled tests for support nested value classes (issue: 859)
@kpadhiamex

Copy link
Copy Markdown
Author

@Raibaz Could you please review this PR?

@Raibaz

Raibaz commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

Out of curiosity, why are you converting the class names to strings when doing comparisons? Does the class to class comparison not work?

@kpadhiamex

kpadhiamex commented Jan 3, 2025 •

Copy link
Copy Markdown
Author

@Raibaz
Used class comparison now, I tried that earlier which didn't work but tried again in an another way which worked fine. Could you please review again?

@Raibaz

Raibaz commented Jan 4, 2025

Copy link
Copy Markdown
Collaborator

Thanks for putting this together and for the follow up commits!

@Raibaz
Raibaz merged commit 59d8d16 into mockk:master Jan 4, 2025
@kpadhiamex
kpadhiamex deleted the 1073-fix-issue-with-mocking-value-classes-with-coEvery branch January 5, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants