Repository navigation
feat(codeStyle): enforce top-level-function - #1033
Merged
Merged
Conversation
ShGKme
commented
May 13, 2025
ShGKme
commented
Contributor
- Fix: [RFC] Top-level function style #1003
- Ref: https://docs.nextcloud.com/server/latest/developer_manual/getting_started/coding_standards/javascript.html#id11
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
susnux
approved these changes
May 13, 2025
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
👍 for the rule
But is there no upstream rule in stylistic? Or something we already use?
Contributor
Author
No :( There is And |
Contributor
Author
|
but the plugin is quite small |
Antreesy
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.