Skip to content

fix: no-deprecated-library-* rules incorrectly behave for nextcloud/vue syntax - #1452

Merged
susnux merged 4 commits into
mainfrom
fix/1001/adjust-rules
Jul 4, 2026
Merged

susnux merged 4 commits into
mainfrom
fix/1001/adjust-rules

Conversation

@Antreesy

@Antreesy Antreesy commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Minor adjustments for nextcloud/vue deprecation rules (due to changes made upstream and former mistakes):

  • converted path @nextcloud/vue/mixins/* does not exist in both v8 and v9 - should throw error, not replace
  • some deprecations were marked for incorrect versions
  • arrowRight was a value (not a prop) and always camelCase
  • cachedMap is a Map(), but methods weren't used

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI
    • Assisted-by: ClaudeCode:claude-opus-4-8

Antreesy added 4 commits July 4, 2026 14:26
- converted path vue/mixins/* does not exist in v8 and v9

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Maksim Sukharev <[email protected]>
- versions were incorrectly documented in the rule

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Maksim Sukharev <[email protected]>
- arrowRight / arrowEnd was always camelCase

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Maksim Sukharev <[email protected]>
- has, get, set should be used for Map()

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
Antreesy requested review from ShGKme and susnux July 4, 2026 14:05
@Antreesy Antreesy self-assigned this Jul 4, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review AI assisted This PR contains AI-assisted commits labels Jul 4, 2026
@susnux
susnux merged commit 60bb082 into main Jul 4, 2026
8 checks passed
@susnux
susnux deleted the fix/1001/adjust-rules branch July 4, 2026 17:06
@ShGKme

ShGKme commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

P.S. Remember to edit the PR title for changelog generation, so library users and contributors see what's fixed

@Antreesy Antreesy changed the title fix: adjust existing rules fix: no-deprecated-library-* rules incorrectly behave for nextcloud/vue syntax Jul 6, 2026
@susnux susnux mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants