Repository navigation
Conversation
susnux
requested review from
ChristophWurst,
ShGKme,
juliusknorr and
skjnldsv
January 14, 2025 13:14
skjnldsv
approved these changes
Jan 14, 2025
skjnldsv
left a comment
skjnldsv
left a comment
Contributor
There was a problem hiding this comment.
Jesus, what a beast of a PR 😅
Contributor
For this specific use case, might be worth it yep |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provides a modular build configuration in flat config format (ESLint v9) as v8 is now EOL.
Please note that this changes some formatting and some warnings might be different, as standard-js seems to be dead and instead we use now more popular plugins / do it our self according to our code styles.
Mostly you might see more formatting or arrays to git diff friendly multi-line versions.
TODO
Do we want to move the nextcloud plugin simply to this repository? Both have more or less a one-to-one relation ship, so maintaining both packages does not make that much sense for me.
So either:
pluginsdirectory