Skip to content

add context info about wrong span or trace - #6703

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
zeitlinger:trace-assert-index
Sep 18, 2024
Merged

jack-berg merged 1 commit into
open-telemetry:mainfrom
zeitlinger:trace-assert-index

Conversation

@zeitlinger

Copy link
Copy Markdown
Member

No description provided.

@zeitlinger
zeitlinger requested a review from a team September 10, 2024 12:06
@zeitlinger zeitlinger self-assigned this Sep 10, 2024
@codecov

codecov Bot commented Sep 10, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (9ddccad) to head (6b41848).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6703   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity     6390     6390           
=========================================
  Files           711      711           
  Lines         19333    19333           
  Branches       1891     1891           
=========================================
  Hits          17418    17418           
  Misses         1335     1335           
  Partials        580      580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zeitlinger

Copy link
Copy Markdown
Member Author

@jack-berg this really helps with complicated asserts

@jkwatson jkwatson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jack-berg
jack-berg merged commit c9c857c into open-telemetry:main Sep 18, 2024
@zeitlinger
zeitlinger deleted the trace-assert-index branch September 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants