Repository navigation
Resolve the pager command once, in _pager_contextmanager - #3776
Merged
Rowlando13 merged 1 commit intoAug 18, 2026
Merged
Conversation
kdeldycke
added
the
help output
kdeldycke
added
prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the refactor of #3767, I just noticed an opportunity to deduplicate the
shutil.whichcall that appears both in_pipepager()and_tempfilepager(). These methods are were already a source of a lot of tweaking these past few years so this should make them more readable.Also used the opportunity to remove unnecessary
if color is None: color = Falselines which made superfluous normalization inside each strategy. The color interpretation is already handled by the new_PagerWriter.