Repository navigation
Add normalizeVariadic to RPUSHX and LPUSHX commands - #1633
Merged
vladvildanov merged 3 commits intoFeb 11, 2026
Merged
Conversation
RPUSHX and LPUSHX commands were missing the setArguments method
with normalizeVariadic call, unlike their RPUSH and LPUSH counterparts.
This caused errors when passing values as a single array argument
(e.g. $client->rpushx('key', ['val1', 'val2'])).
Fixes predis#1504
tillkruss
approved these changes
Feb 8, 2026
Member
|
Time for a release soon? |
vladvildanov
approved these changes
Feb 9, 2026
Contributor
|
@tillkruss Let's release along with Redis 8.6, it should happen this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RPUSHXandLPUSHXcommands were missing thesetArgumentsmethod withnormalizeVariadiccall, unlike theirRPUSHandLPUSHcounterparts.This caused errors when passing values as an array:
Changes
setArguments()withnormalizeVariadic()toRPUSHXandLPUSHXcommandstestFilterArgumentsValuesAsSingleArraytests for both commandsFixes #1504