Repository navigation
Fix env_file from model_config ignored in CliApp.run() (#795) - #796
Merged
Merged
Conversation
The _env_file default in _settings_init_sources was None instead of ENV_FILE_SENTINEL, causing the model_config env_file to be skipped when CliApp.run() calls _settings_init_sources without _env_file. Co-Authored-By: Claude Opus 4.6 <[email protected]>
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _env_file default in _settings_init_sources was None instead of ENV_FILE_SENTINEL, causing the model_config env_file to be skipped when CliApp.run() calls _settings_init_sources without _env_file.