Skip to content

fix: preserve workspace context for Rspack binding install - #71

Merged
chenjiahan merged 1 commit into
mainfrom
seal/fix-rspack-binding-install
Jul 27, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
seal/fix-rspack-binding-install

Conversation

@LingyuCoder

@LingyuCoder LingyuCoder commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Install @rspack/binding dependencies through the Rspack workspace instead of running an isolated install from crates/node_binding.

Rspack now uses pnpm catalog specifiers for the binding's development dependencies. The existing --ignore-workspace install cannot resolve those catalogs and, after it fails, leaves the shell in crates/node_binding, causing the later root build script to fail as a secondary error.

Using pnpm --filter @rspack/binding install --frozen-lockfile preserves workspace catalog resolution, keeps the working directory stable, and matches Rspack's current binding build workflow.

This is Rspack-specific because it is the only stack with a native binding preparation job. The action is consumed from this repository's main, so no action release or SHA pin update is required after merge.

Validation

  • pnpm lint
  • Against web-infra-dev/rspack@fe6890c7e11829a6459f1e9641b28aace4c0c268:
    • pnpm i --frozen-lockfile
    • pnpm --filter @rspack/binding install --frozen-lockfile
    • cargo codegen
    • pnpm run build:binding:release
  • Full Ecosystem CI against web-infra-dev/rspack#14741: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/30258401733
    • Prepare Rspack Binding succeeded and uploaded binding-linux-x64-gnu.
    • All ecosystem suites succeeded.

Related links

@LingyuCoder
LingyuCoder marked this pull request as ready for review July 27, 2026 10:54
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e49df5c7-f8ed-4b44-9113-7dc8d112267d

📥 Commits

Reviewing files that changed from the base of the PR and between 15a6698 and 56bf6c4.

📒 Files selected for processing (1)
  • .github/actions/prepare-rspack-binding/action.yaml

📝 Walkthrough

Walkthrough

Updated the Build Rspack action step to install @rspack/binding with pnpm’s package filter and frozen lockfile. The subsequent code generation, release build, and artifact upload flow remains unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: switching the Rspack binding install to preserve workspace context.
Description check ✅ Passed The description accurately describes the workspace-based binding install change and its motivation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch seal/fix-rspack-binding-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit ce2f546 into main Jul 27, 2026
48 checks passed
@chenjiahan
chenjiahan deleted the seal/fix-rspack-binding-install branch July 27, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants