fix: preserve workspace context for Rspack binding install - #71
Merged
Merged
Conversation
LingyuCoder
marked this pull request as ready for review
July 27, 2026 10:54
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Build Rspack action step to install 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chenjiahan
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install
@rspack/bindingdependencies through the Rspack workspace instead of running an isolated install fromcrates/node_binding.Rspack now uses pnpm catalog specifiers for the binding's development dependencies. The existing
--ignore-workspaceinstall cannot resolve those catalogs and, after it fails, leaves the shell incrates/node_binding, causing the later root build script to fail as a secondary error.Using
pnpm --filter @rspack/binding install --frozen-lockfilepreserves workspace catalog resolution, keeps the working directory stable, and matches Rspack's current binding build workflow.This is Rspack-specific because it is the only stack with a native binding preparation job. The action is consumed from this repository's
main, so no action release or SHA pin update is required after merge.Validation
pnpm lintweb-infra-dev/rspack@fe6890c7e11829a6459f1e9641b28aace4c0c268:pnpm i --frozen-lockfilepnpm --filter @rspack/binding install --frozen-lockfilecargo codegenpnpm run build:binding:releaseweb-infra-dev/rspack#14741: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/30258401733Prepare Rspack Bindingsucceeded and uploadedbinding-linux-x64-gnu.Related links