Repository navigation
DOC Release highlights 1.5 - #29007
Conversation
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
Looking good. Two little grammar comments
Co-authored-by: Tim Head <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
lorentzenchr
left a comment
lorentzenchr
left a comment
There was a problem hiding this comment.
Thanks for putting this together. Mostly optional suggestions.
| # <sphx_glr_auto_examples_model_selection_plot_cost_sensitive_learning.py>`. | ||
|
|
||
| # %% | ||
| # Performance improvements in PCA |
There was a problem hiding this comment.
Not actionable: I know we are a bit thin with big new things and this is one of them. But we did not list the newton-cholesky solver in 1.2 as a highlight.
There was a problem hiding this comment.
I think we should have promoted the newton-cholesky in 1.2.
If I put on my "developer relationships" hat on, I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.
There was a problem hiding this comment.
But we did not list the newton-cholesky solver in 1.2 as a highlight.
It could have but all the reviewers for the 1.2 highlights missed it, including me. That said there were already many entries in the 1.2 highlights and there's always a compromise to make.
I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.
I don't think adding a new entry today in the 1.2 highlights is relevant. It's already not even accessible from the front page. I expect a very low traffic on this page now.
|
@scikit-learn/core-devs ping in case you want to have a look. |
Co-authored-by: Christian Lorentzen <[email protected]>
|
Alright, let's merge to not delay the release. If we want to do something about #29007 (comment), we can still open a separate PR and backport in 1.5.X, it's just doc anyway. |
Co-authored-by: Tim Head <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]>
Co-authored-by: Tim Head <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Christian Lorentzen <[email protected]>
5 participants
No description provided.