Skip to content

4.x: Make all queries to system.local use WHERE clause - #436

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
dkropachev:dk/fix-system-local-query
Feb 14, 2025
Merged

dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
dkropachev:dk/fix-system-local-query

Conversation

@dkropachev

@dkropachev dkropachev commented Feb 14, 2025 •

Copy link
Copy Markdown

Full scan requests slower even when only one record there is.

Fixes: #282

@dkropachev
dkropachev force-pushed the dk/fix-system-local-query branch 2 times, most recently from c9e61b3 to 5f9f96b Compare February 14, 2025 03:48
@dkropachev dkropachev changed the title Make all queries to system.local use WHERE clause 4.x: Make all queries to system.local use WHERE clause Feb 14, 2025
@dkropachev
dkropachev force-pushed the dk/fix-system-local-query branch from 5f9f96b to a45d591 Compare February 14, 2025 12:59
Full scan requests slower even when only one record there is
@dkropachev
dkropachev force-pushed the dk/fix-system-local-query branch from a45d591 to 6f88a5c Compare February 14, 2025 13:02
@mykaul

mykaul commented Feb 14, 2025

Copy link
Copy Markdown

Unclear to me what doesn't pass the tests here yet.

@dkropachev

Copy link
Copy Markdown
Author

Unclear to me what doesn't pass the tests here yet.

failure was not related to the test, I have restarted it and now it works.

@dkropachev
dkropachev requested a review from Bouncheck February 14, 2025 18:19

@Bouncheck Bouncheck left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just as a sanity check: there is no case where the key would not be 'local', right?

@dkropachev
dkropachev merged commit 663064f into scylladb:scylla-4.x Feb 14, 2025
@dkropachev

Copy link
Copy Markdown
Author

LGTM. Just as a sanity check: there is no case where the key would not be 'local', right?

correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suboptimal queries on Session/Connection initiation in version 4.17

3 participants