Repository navigation
reject timestamp response missing the requested nonce - #1405
Merged
Merged
Conversation
Signed-off-by: dxbjavid <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
===========================================
- Coverage 52.85% 26.55% -26.30%
===========================================
Files 20 55 +35
Lines 1209 3137 +1928
===========================================
+ Hits 639 833 +194
- Misses 509 2252 +1743
+ Partials 61 52 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thank you for reviewing and merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verifyNonce compares the caller's expected nonce against the nonce parsed from the response, but the nonce is optional in an RFC 3161 reply, so a validly signed response that omits it leaves the parsed value nil and the comparison panics once a caller has requested a nonce. It is reachable after the signature and chain have already verified, for instance when an older timestamp carrying no nonce is replayed for the same artefact. Reject a response that lacks the expected nonce rather than dereferencing it, which also lines up with RFC 3161 2.4.2 requiring a requested nonce to be echoed back.